Fix incorrect suggestion for package that bundles types #45507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
gabritto
commented
Aug 19, 2021
src/compiler/types.ts
Outdated
| /** Version of the package, e.g. "1.2.3" */ | ||
| version: string; | ||
| /** Whether the package bundles its own type declarations. */ | ||
| bundlesTypes?: boolean; |
There was a problem hiding this comment.
if there's a more official naming for this option, I'm open to renaming it
gabritto
commented
Aug 19, 2021
andrewbranch
approved these changes
Aug 19, 2021
andrewbranch
approved these changes
Aug 20, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43488